Messages in this thread | | | From | Dmitry Torokhov <> | Subject | Re: [PATCH v6 2/5] MFD: RK808: Add new mfd driver for RK808 | Date | Wed, 27 Aug 2014 10:21:38 -0700 |
| |
On Wednesday, August 27, 2014 02:39:36 PM Lee Jones wrote: > On Tue, 26 Aug 2014, Chris Zhong wrote: > > + > > +static struct of_device_id rk808_of_match[] = { > > + { .compatible = "rockchip,rk808" }, > > +}; > > +MODULE_DEVICE_TABLE(of, rk808_of_match); > > + > > +static const struct i2c_device_id rk808_ids[] = { > > + { "rk808" }, > > +}; > > + > > +MODULE_DEVICE_TABLE(i2c, rk808_ids); > > My OCD senses are tingling. Either have a blank line above the calls > to MODULE_DEVICE_TABLE() or don't.
Wait, don't we also need sentinel entries in both these tables?
Thanks, Dmitry
| |