Messages in this thread | | | Date | Wed, 27 Aug 2014 10:08:24 -0700 | From | "Paul E. McKenney" <> | Subject | Re: [PATCH tip/core/rcu 1/2] rcu: Parallelize and economize NOCB kthread wakeups |
| |
On Wed, Aug 27, 2014 at 12:43:01PM -0400, Pranith Kumar wrote: > On Wed, Aug 27, 2014 at 12:21 PM, Paul E. McKenney > <paulmck@linux.vnet.ibm.com> wrote: > > On Wed, Aug 27, 2014 at 10:13:50AM +0530, Amit Shah wrote: > > >> > >> Yes, this patch helps my case as well. > > > > Very good!!! > > > > Pranith, I can take this patch, but would you be willing to invert > > the sense of ->nocb_leader_wake (e.g., call it ->nocb_leader_sleep or > > some such)? This field is only used in eight places in the source code. > > > > The idea is that inverting the sense of the field allows the normal C > > initialization of zero to properly initialize this field, plus it gets > > rid of a few lines of code. > > Sure, that is indeed a good idea. I will send a new patch.
Very good, looking forward to seeing it!
Thanx, Paul
| |