lkml.org 
[lkml]   [2014]   [Aug]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 1/5] perf, x86: Remove incorrect model number from Haswell perf
    On Mon, 25 Aug 2014, Andi Kleen wrote:

    > From: Andi Kleen <ak@linux.intel.com>
    >
    > Signed-off-by: Andi Kleen <ak@linux.intel.com>
    > ---
    > arch/x86/kernel/cpu/perf_event_intel.c | 3 +--
    > 1 file changed, 1 insertion(+), 2 deletions(-)
    >
    > diff --git a/arch/x86/kernel/cpu/perf_event_intel.c b/arch/x86/kernel/cpu/perf_event_intel.c
    > index 89bc750..e280a86 100644
    > --- a/arch/x86/kernel/cpu/perf_event_intel.c
    > +++ b/arch/x86/kernel/cpu/perf_event_intel.c
    > @@ -2541,10 +2541,9 @@ __init int intel_pmu_init(void)
    >
    >
    > case 60: /* 22nm Haswell */
    > + case 70:
    > case 63:
    > case 69:
    > - case 70:
    > - case 71:

    So what's the point of making the obvious onliner patch

    - case 71:

    into something which reorders the sorted case numbers?

    And of course, this patch is missing any explanation WHY 71 is
    incorrect and how it got there in the first place.

    Thanks,

    tglx




    \
     
     \ /
      Last update: 2014-08-26 23:41    [W:2.756 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site