Messages in this thread | | | Date | Tue, 26 Aug 2014 11:37:29 -0700 | Subject | Re: [PATCH v6 1/5] dt-bindings: Add RK808 device tree bindings document | From | Doug Anderson <> |
| |
Chris,
On Tue, Aug 26, 2014 at 7:11 AM, Chris Zhong <zyw@rock-chips.com> wrote: > Add device tree bindings documentation and a header file > for rockchip's RK808 pmic. > > Signed-off-by: Chris Zhong <zyw@rock-chips.com> > Signed-off-by: Zhang Qing <zhangqing@rock-chips.com> > > --- > > Changes in v6: > Advices by Mark Rutland > - add description about clock-cells > Advices by Doug > - modify description about regulator > - remove pinctrl description > > Changes in v5: > Advices by Mark Brown > - add description about regulator valid name. > - add a header file "rockchip,rk808". > > Changes in v4: > Advices by Doug > - add a "#clock-cells" propertiy > - update the example > > Changes in v3: None > Changes in v2: None > > Documentation/devicetree/bindings/mfd/rk808.txt | 150 +++++++++++++++++++++++ > include/dt-bindings/clock/rockchip,rk808.h | 11 ++ > 2 files changed, 161 insertions(+)
Is it worth picking a new example from <https://patchwork.kernel.org/patch/4783471/>? Then if someone happens to copy your example the'll get slightly more sane things (level low for interrupt, wakeup-source, proper "clock-output-name" that's compatible with rk3288, etc.
Other than that this looks find to me:
Reviewed-by: Doug Anderson <dianders@chromium.org>
| |