lkml.org 
[lkml]   [2014]   [Aug]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 16/18] backlight: jornada720: remove 'else' after a return
    On Tue, 26 Aug 2014, Jingoo Han wrote:

    > Fixed the following checkpatch warning.
    >
    > WARNING: else is not generally useful after a break or return
    >
    > Signed-off-by: Jingoo Han <jg1.han@samsung.com>
    > ---
    > drivers/video/backlight/jornada720_bl.c | 6 +++---
    > 1 file changed, 3 insertions(+), 3 deletions(-)

    Acked-by: Lee Jones <lee.jones@linaro.org>

    > diff --git a/drivers/video/backlight/jornada720_bl.c b/drivers/video/backlight/jornada720_bl.c
    > index 6ce96b4a8796..7e6ff5346892 100644
    > --- a/drivers/video/backlight/jornada720_bl.c
    > +++ b/drivers/video/backlight/jornada720_bl.c
    > @@ -41,11 +41,11 @@ static int jornada_bl_get_brightness(struct backlight_device *bd)
    > dev_err(&bd->dev, "get brightness timeout\n");
    > jornada_ssp_end();
    > return -ETIMEDOUT;
    > - } else {
    > - /* exchange txdummy for value */
    > - ret = jornada_ssp_byte(TXDUMMY);
    > }
    >
    > + /* exchange txdummy for value */
    > + ret = jornada_ssp_byte(TXDUMMY);
    > +
    > jornada_ssp_end();
    >
    > return BL_MAX_BRIGHT - ret;

    --
    Lee Jones
    Linaro STMicroelectronics Landing Team Lead
    Linaro.org │ Open source software for ARM SoCs
    Follow Linaro: Facebook | Twitter | Blog
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2014-08-26 19:01    [W:3.350 / U:0.236 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site