Messages in this thread | | | Date | Tue, 26 Aug 2014 10:50:59 -0400 | From | Tejun Heo <> | Subject | Re: [PATCH v2] ata: ahci_tegra: Read calibration fuse |
| |
On Tue, Aug 26, 2014 at 12:00:30PM +0300, Mikko Perttunen wrote: > The original version of the driver did not read the SATA calibration > fuse to remove the dependency to the fuse driver. The fuse driver > is now merged, so add this functionality. > > The calibration fuse contains a 2-bit value used to pick a set > of calibration values for the SATA pad. > > Signed-off-by: Mikko Perttunen <mperttunen@nvidia.com>
Applied to libata/for-3.17-fixes. One comment below.
> #include <linux/ahci_platform.h> > -#include <linux/reset.h> > #include <linux/errno.h> > #include <linux/kernel.h> > #include <linux/module.h> > #include <linux/of_device.h> > #include <linux/platform_device.h> > #include <linux/regulator/consumer.h> > +#include <linux/reset.h>
You moved the include of reset.h w/o any explanation in the patch description. The description doesn't have to be super verbose on trivial stuff but it at least has to cover all changes included in the patch w/ their rationales, however trivial they may be.
Thanks.
-- tejun
| |