lkml.org 
[lkml]   [2014]   [Aug]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v6 2/4] net: moxa: replace build_skb() with netdev_alloc_skb_ip_align() / memcpy()
From
From: Jonas Jensen <jonas.jensen@gmail.com>
Date: Mon, 25 Aug 2014 16:22:22 +0200

> build_skb() is used to make skbs out of existing RX ring memory
> which is bad because the RX ring is allocated only once, on probe.
> Memory corruption occur because said memory is reclaimed, i.e.
> __kfree_skb() (and eventually put_page()).
>
> Replace build_skb() with netdev_alloc_skb_ip_align() and use memcpy().
>
> Remove SKB_DATA_ALIGN() from RX buffer size while we're at it.
>
> Addresses https://bugzilla.kernel.org/show_bug.cgi?id=69041
>
> Signed-off-by: Jonas Jensen <jonas.jensen@gmail.com>

Applied.


\
 
 \ /
  Last update: 2014-08-26 02:41    [W:0.064 / U:0.432 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site