Messages in this thread | | | Date | Mon, 25 Aug 2014 16:18:01 -0400 | From | "John W. Linville" <> | Subject | Re: [PATCH 11/19] iwl4965: fix %d confusingly prefixed with 0x in format string |
| |
On Sun, Aug 03, 2014 at 05:20:05PM -0700, Hans Wennborg wrote: > Signed-off-by: Hans Wennborg <hans@hanshq.net> > --- > drivers/net/wireless/iwlegacy/4965-mac.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/wireless/iwlegacy/4965-mac.c b/drivers/net/wireless/iwlegacy/4965-mac.c > index c159c05..7d6fd59 100644 > --- a/drivers/net/wireless/iwlegacy/4965-mac.c > +++ b/drivers/net/wireless/iwlegacy/4965-mac.c > @@ -4633,7 +4633,7 @@ il4965_store_tx_power(struct device *d, struct device_attribute *attr, > else { > ret = il_set_tx_power(il, val, false); > if (ret) > - IL_ERR("failed setting tx power (0x%d).\n", ret); > + IL_ERR("failed setting tx power (0x%x).\n", ret); > else > ret = count; > }
It seems like that should be "0x%08x" or similar, no?
-- John W. Linville Someday the world will need a hero, and you linville@tuxdriver.com might be all we have. Be ready.
| |