Messages in this thread | | | Date | Sun, 24 Aug 2014 20:13:42 -0700 | Subject | Re: [Bug 3.14.17] inconsistent lock state | From | Linus Torvalds <> |
| |
On Sun, Aug 24, 2014 at 7:53 PM, Lan Tianyu <tianyu.lan@intel.com> wrote: > > Sorry about this. We are resolving the issue in the other bug > report(https://lkml.org/lkml/2014/8/21/606) and I have proposed a fix > patch(http://marc.info/?l=linux-acpi&m=140869309231199&w=2).
Ahh. Good. That patch looks fine to me, and while it makes me worry a bit that some codepath expects the power/sleep button to be handled immediately in interrupt context, I guess the actual callbacks have never actually done anything but schedule other things to happen (ie add events to some queue), and making the context be the same as the other notify callbacks would seem to be a good thing regardless of this particular bug.
Knut - can you please test the patch Lan pointed at? I realize it doesn't seem to be entirely consistent for you (which is a bit surprising, I wonder why lockdep doesn't trigger it consistently), but it would be good to have more testing. Even if that patch looks "obviously good" (tm) at a quick glance.
Linus
| |