lkml.org 
[lkml]   [2014]   [Aug]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 2/5] x86, fpu: don't drop_fpu() in __restore_xstate_sig() if use_eager_fpu()
From
I really dislike this one.

If I read it right, you now do *two* math_state_restore calls for each
FPU signal state restore. That's potentially quite expensive.

Also, you can actually end up with multiple threads pointing to the
same math state in init_task.thread.fpu.state, right? Why is that any
better than just having the save state temporarily contain garbage?

The other patches look sane, this one I really don't like. You may
have good reasons for it, but it's disgusting.

Linus

On Sun, Aug 24, 2014 at 12:47 PM, Oleg Nesterov <oleg@redhat.com> wrote:
> __restore_xstate_sig() calls math_state_restore() with preemption
> enabled, not good. But this is minor, [...]


\
 
 \ /
  Last update: 2014-08-24 22:21    [W:0.076 / U:0.052 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site