Messages in this thread | | | Date | Sat, 23 Aug 2014 07:00:44 -0700 | From | Guenter Roeck <> | Subject | Re: [PATCH v2 1/2] pmbus: add regulator support |
| |
On 08/22/2014 05:31 PM, atull wrote: > On Fri, 22 Aug 2014, Mark Brown wrote: > >> On Fri, Aug 22, 2014 at 04:11:33PM -0500, atull@opensource.altera.com wrote: >> >>> + if (pdata && pdata->reg_init_data) { >>> + config.init_data = pdata->reg_init_data; >>> + } else { >>> + config.init_data = of_get_regulator_init_data(dev, np); >>> + if (!config.init_data) >>> + return -ENOMEM; >>> + } >> >> It should be fine to start with no init data - just let the regulator >> core worry about it. This will allow users to read back the state even >> if they can't change anything which is useful for system bringup or >> general debugging. >> > > of_get_regulator_init_data() will only have an error if it cannot alloc > the regulator_init_data struct. That's why I did -ENOMEM. If there > is no platform data and nothing about the regulator in the device tree, we > should end up with a zeroed out regulator_init_data. > Yes, but if OF is not defined it will return NULL as well. Unless I am missing something, that means that the code will now fail if there is no platform init data and OF is not configured.
Guenter
| |