Messages in this thread | | | Date | Sat, 23 Aug 2014 20:55:17 -0400 | From | Peter Feiner <> | Subject | Re: [PATCH v2 1/3] mm: softdirty: enable write notifications on VMAs after VM_SOFTDIRTY cleared |
| |
On Sun, Aug 24, 2014 at 02:50:58AM +0300, Kirill A. Shutemov wrote: > One more case to consider: mprotect() which doesn't trigger successful > vma_merge() will not set VM_SOFTDIRTY and will not enable write-protect on > the vma. > > It's probably better to take VM_SOFTDIRTY into account in > vma_wants_writenotify() and re-think logic in other corners.
Merge or not, write notifications get disabled! I'll fix this too :-)
Peter
| |