Messages in this thread | | | Date | Wed, 20 Aug 2014 22:26:02 +0200 | From | Pavel Machek <> | Subject | Re: [PATCH 1/1] spi: Remove unused definitions |
| |
On Wed 2014-08-06 14:27:20, Valdis.Kletnieks@vt.edu wrote: > On Wed, 06 Aug 2014 13:53:17 -0400, Nick Krause said: > > Remove unused definition which cause the following warnings > > > > drivers/spi/spi-omap-100k.c:73:0: warning: "WRITE" redefined [enabled by default] > > include/linux/fs.h:193:0: note: this is the location of the previous definition > > drivers/spi/spi-omap-100k.c:74:0: warning: "READ" redefined [enabled by default] > > include/linux/fs.h:192:0: note: this is the location of the previous definition > > > -#define WRITE 0 > > -#define READ 1 > > NAK. Full stop. These are potentially used in an inner macro someplace, and by > removing these, the conflicting values from fs.h will be used instead. > > #define READ 0 > #define WRITE RW_MASK > > So if there *is* a use in an inner macro, you just screwed the pooch > and introduced a bug in this "clean up" - somebody will be expecting to see > a 0 for a READ, and will receive a 1 instead. This can't end well.
Actually.. having macros called READ and WRITE in fs.h is already something I'd say can't end well. Can we rename those?
-- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
| |