Messages in this thread | | | From | Pranith Kumar <> | Date | Wed, 20 Aug 2014 09:29:10 -0400 | Subject | Re: [PATCH] booke_wdt: Fix build failure as a module |
| |
On Wed, Aug 20, 2014 at 9:25 AM, Guenter Roeck <linux@roeck-us.net> wrote: > On Tue, Aug 19, 2014 at 11:12:07PM -0400, Pranith Kumar wrote: >> Building booke_wdt fails when trying to build as a module as there is no >> early_param() in module. Fix by enclosing within MODULE check. >> > Might make more sense to replace the early_param with a normal module parameter. > Taking the module parameter away if the driver is built as module seems to be > a bit excessive. > > Any idea why early_param was chosen over a standard module parameter ?
I didn't really investigate. This showed up in a randconfig build error. I will try to convert this to module param. Thanks!
-- Pranith
| |