lkml.org 
[lkml]   [2014]   [Aug]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH net-next 3/4] r8152: remove clear_bp function
Hello.

On 8/20/2014 12:58 PM, Hayes Wang wrote:

> The functions are used to update the firmware. Move the actions into
> the firmware files.

> Signed-off-by: Hayes Wang <hayeswang@realtek.com>
> ---
> drivers/net/usb/r8152.c | 24 ------------------------
> 1 file changed, 24 deletions(-)

> diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c
> index 33dcc97..937d132 100644
> --- a/drivers/net/usb/r8152.c
> +++ b/drivers/net/usb/r8152.c
[...]
> @@ -2248,7 +2226,6 @@ static void r8152b_hw_phy_cfg(struct r8152 *tp)
>
> r8152b_disable_aldps(tp);
>
> - rtl_clear_bp(tp);
>

Why leave 2 empty lines? One is enough.

> r8152b_enable_aldps(tp);
> set_bit(PHY_RESET, &tp->flags);
> @@ -2404,7 +2381,6 @@ static void r8153_hw_phy_cfg(struct r8152 *tp)
> r8152_mdio_write(tp, MII_BMCR, data);
> }
>
> - r8153_clear_bp(tp);
>

Ditto.

> if (tp->version == RTL_VER_03) {
> data = ocp_reg_read(tp, OCP_EEE_CFG);
>

WBR, Sergei



\
 
 \ /
  Last update: 2014-08-20 14:21    [W:0.292 / U:1.300 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site