Messages in this thread | | | Date | Wed, 20 Aug 2014 12:21:58 +0200 | From | Javier Martinez Canillas <> | Subject | Re: [PATCH 5/6] ARM: dts: Add vmmc and vqmmc supplies for Peach Pit and Pi boards |
| |
Hello Andreas,
Thanks a lot for your feedback.
On 08/19/2014 08:37 PM, Andreas Färber wrote: >> &mmc_2 { >> + vmmc-supply = <&tps65090_fet4>; >> + vqmmc-supply = <&vqmmc_sdcard>; >> status = "okay"; >> num-slots = <1>; >> supports-highspeed; > > A convention that I picked up was to place overridden status property > first. Do your new properties really need to go before that? >
OF doesn't care about the order of the child nodes but I do agree that consistency is a good thing so I'll change that on v2.
> Also, if you look at today's for-next, then supports-highspeed should be > cap-{sd,mmc}-highspeed, so it may be worth to rebase. >
You are right, this patch used to be part of an older series so I didn't realize that "[PATCHv10 3/5] ARM: dts: exynos: unuse the slot-node and deprecate the supports-highspeed for dw-mmc" was already merged. Thanks for the reminder!
> Regards, > Andreas >
Best regards, Javier -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |