Messages in this thread | | | Subject | Re: [PATCH v2 08/18] ARM64 / ACPI: Get the enable method for SMP initialization in ACPI way | From | Geoff Levand <> | Date | Tue, 19 Aug 2014 12:25:26 -0700 |
| |
Hi Hanjun,
On Tue, 2014-08-19 at 20:11 +0800, Hanjun Guo wrote: > On 2014-8-19 2:56, Geoff Levand wrote:
> > message = acpi_disabled ? dn->full_name : ""; > > > > ... > > > > pr_warn("CPU %d: %s unsupported enable-method property: %s\n", > > cpu, message, enable_method) > > In ACPI, there is no enable-method property, it is a term from, so I think the > message printed can be separated.
I think it better to have a single message that can cover all than to have separate messages. Wouldn't the enable method be "acpi-parking" or "acpi-psci"? Then something like this would work:
pr_warn("CPU %d: %s Unsupported enable method: %s\n", cpu, message, enable_method);
-Geoff
| |