Messages in this thread | | | Date | Tue, 19 Aug 2014 07:58:21 -0400 | From | Peter Hurley <> | Subject | Re: [PATCH v9 12/16] serial: amba-pl011: Pass FIQ information to KGDB. |
| |
On 08/19/2014 05:08 AM, Daniel Thompson wrote: > On 18/08/14 19:30, Peter Hurley wrote:
[cut]
>>> +static int pl011_poll_init(struct uart_port *port) >>> +{ >>> + struct uart_amba_port *uap = (struct uart_amba_port *)port; >> >> Please use container_of() in new code. > > Ok. > > Personally I dislike a file that mixes casts and conatiner_of but I > guess I can make both of us happy by switching the whole driver to > container_of. Separate patch again?
The change below makes the uap local unnecessary, so you can skip the container_of() change, if you'd prefer.
>>> + int retval; >>> + >>> + retval = pl011_hwinit(port); >>> + >>> +#ifdef CONFIG_KGDB_FIQ >>> + if (retval == 0) >>> + kgdb_register_fiq(uap->port.irq); >> >> The uap->port dereference is unnecessary since the port parameter >> is the same thing. >> >> kgdb_register_fiq(port->irq); > > Ok.
Thanks, Peter Hurley
| |