lkml.org 
[lkml]   [2014]   [Aug]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/2] gpio: acpi: normalize use of gpiochip_get_desc()
On Mon, Aug 18, 2014 at 09:50:56AM -0700, Alexandre Courbot wrote:
> GPIO descriptors are changing from unique and permanent tokens to
> allocated resources. Therefore gpiochip_get_desc() cannot be used as a
> way to obtain a global GPIO descriptor anymore.
>
> This patch updates the gpiolib ACPI support code to keep and use the
> descriptor returned by a centralized call to gpiochip_get_desc().
>
> Signed-off-by: Alexandre Courbot <acourbot@nvidia.com>
> ---
> drivers/gpio/gpiolib-acpi.c | 22 ++++++++++++++--------
> 1 file changed, 14 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/gpio/gpiolib-acpi.c b/drivers/gpio/gpiolib-acpi.c
> index d62eaaa75397..9596a1023579 100644
> --- a/drivers/gpio/gpiolib-acpi.c
> +++ b/drivers/gpio/gpiolib-acpi.c
> @@ -25,10 +25,12 @@ struct acpi_gpio_event {
> acpi_handle handle;
> unsigned int pin;
> unsigned int irq;
> + gpio_desc *desc;

This needs to be
struct gpio_desc *desc;

> };

Tested on Asus T100TA and nothing seems to break, so:

Tested-by: Mika Westerberg <mika.westerberg@linux.intel.com>


\
 
 \ /
  Last update: 2014-08-19 11:41    [W:0.089 / U:0.012 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site