Messages in this thread | | | Date | Tue, 19 Aug 2014 12:27:53 +0300 | From | Mika Westerberg <> | Subject | Re: [RFC PATCH 8/9] Input: gpio_keys_polled - Make use of device property API |
| |
On Mon, Aug 18, 2014 at 10:55:12AM -0700, Jacob Pan wrote: > On Sat, 16 Aug 2014 09:53:58 +0300 > Mika Westerberg <mika.westerberg@linux.intel.com> wrote: > > > From: Aaron Lu <aaron.lu@intel.com> > > > > Make use of device property API in this driver so that both OF based > > system and ACPI based system can use this driver. > > > Do we always assume OF and ACPI _DSD will have the same property name > strings? i.e. in this patch "gpios" > > + if (device_property_get(dev, "gpios", NULL)) { > > - if (!of_find_property(pp, "gpios", NULL)) { > > Maybe i missed something, but I don't think we can make that assumption > in BIOS. If not, what is the point of having unified interface?
We recommend that when it makes sense, the property names in _DSD follow the corresponding DT names.
| |