lkml.org 
[lkml]   [2014]   [Aug]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC PATCH 8/9] Input: gpio_keys_polled - Make use of device property API
On Mon, Aug 18, 2014 at 10:55:12AM -0700, Jacob Pan wrote:
> On Sat, 16 Aug 2014 09:53:58 +0300
> Mika Westerberg <mika.westerberg@linux.intel.com> wrote:
>
> > From: Aaron Lu <aaron.lu@intel.com>
> >
> > Make use of device property API in this driver so that both OF based
> > system and ACPI based system can use this driver.
> >
> Do we always assume OF and ACPI _DSD will have the same property name
> strings? i.e. in this patch "gpios"
> > + if (device_property_get(dev, "gpios", NULL)) {
> > - if (!of_find_property(pp, "gpios", NULL)) {
>
> Maybe i missed something, but I don't think we can make that assumption
> in BIOS. If not, what is the point of having unified interface?

We recommend that when it makes sense, the property names in _DSD follow
the corresponding DT names.


\
 
 \ /
  Last update: 2014-08-19 11:41    [W:0.109 / U:0.224 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site