lkml.org 
[lkml]   [2014]   [Aug]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 15/18] perf buildid-cache: Use strerror_r instead of strerror
    Date
    From: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>

    Use strerror_r instead of strerror in error messages for thread-safety.

    Signed-off-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
    Cc: Ingo Molnar <mingo@redhat.com>
    Cc: Namhyung Kim <namhyung@kernel.org>
    Cc: Naohiro Aota <naota@elisp.net>
    Cc: Paul Mackerras <paulus@samba.org>
    Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
    Link: http://lkml.kernel.org/r/20140814022249.3545.53211.stgit@kbuild-fedora.novalocal
    Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
    ---
    tools/perf/builtin-buildid-cache.c | 7 ++++---
    1 file changed, 4 insertions(+), 3 deletions(-)

    diff --git a/tools/perf/builtin-buildid-cache.c b/tools/perf/builtin-buildid-cache.c
    index ac5838e0b1bd..70385756da63 100644
    --- a/tools/perf/builtin-buildid-cache.c
    +++ b/tools/perf/builtin-buildid-cache.c
    @@ -291,6 +291,7 @@ int cmd_buildid_cache(int argc, const char **argv,
    *missing_filename = NULL,
    *update_name_list_str = NULL,
    *kcore_filename;
    + char sbuf[STRERR_BUFSIZE];

    struct perf_data_file file = {
    .mode = PERF_DATA_MODE_READ,
    @@ -347,7 +348,7 @@ int cmd_buildid_cache(int argc, const char **argv,
    continue;
    }
    pr_warning("Couldn't add %s: %s\n",
    - pos->s, strerror(errno));
    + pos->s, strerror_r(errno, sbuf, sizeof(sbuf)));
    }

    strlist__delete(list);
    @@ -365,7 +366,7 @@ int cmd_buildid_cache(int argc, const char **argv,
    continue;
    }
    pr_warning("Couldn't remove %s: %s\n",
    - pos->s, strerror(errno));
    + pos->s, strerror_r(errno, sbuf, sizeof(sbuf)));
    }

    strlist__delete(list);
    @@ -386,7 +387,7 @@ int cmd_buildid_cache(int argc, const char **argv,
    continue;
    }
    pr_warning("Couldn't update %s: %s\n",
    - pos->s, strerror(errno));
    + pos->s, strerror_r(errno, sbuf, sizeof(sbuf)));
    }

    strlist__delete(list);
    --
    1.9.3


    \
     
     \ /
      Last update: 2014-08-15 19:01    [W:2.631 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site