Messages in this thread | | | Date | Fri, 15 Aug 2014 14:01:56 +0200 | From | Javier Martinez Canillas <> | Subject | Re: [PATCH 2/2] Input: atmel_mxt_ts - Add keycodes array example |
| |
Hello Nick,
On 08/08/2014 04:52 PM, Javier Martinez Canillas wrote: On 08/07/2014 02:38 PM, Nick Dyer wrote: >> >> >> >> I'm afraid you have misunderstood the impact of this change to the way that >> the GPIOs coming in to the touch controller are mapped to key codes. Look > > Unfortunately there are no boards in mainline using this "linux,gpio-keymap" > property so I tried to figure out what the expected values were by reading the > driver. So is more than possible that I got them wrong. > > By passing all these keycodes the touchpad worked as expected for me and the > driver did the same than the Chrome OS driver that has these keycodes hardcoded > when is_tp is true. > >> at the protocol guide for T19. >> > > I don't have access to proper documentation and I wouldn't expect people to have > access to non-public docs in order to use a Device Tree binding. > > That's why I wanted to document an example, so using this property could be > easier for others and they shouldn't have to look at the driver in order to > figure it out (and getting it wrong as you said :) ) > > So it would be great if you could provide an example on how this is supposed to > be used. >
Any comments on this? I would really appreciate if you can expand on how this DT property is supposed to be used so I can re-spin the atmel support patch for Peach boards.
Thanks a lot and best regards, Javier
| |