lkml.org 
[lkml]   [2014]   [Aug]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCHv2] HID:hid-logitech: Prevent possibility of infinite loop when using /sys interface
    Date
    If the device data is not accessible for some reason, returning 0 will cause the call to be
    continuously called again as none of the string has been 'consumed'.

    Signed-off-by: Simon Wood <simon@mungewell.org>
    ---
    drivers/hid/hid-lg4ff.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    diff --git a/drivers/hid/hid-lg4ff.c b/drivers/hid/hid-lg4ff.c
    index cc2bd20..7835717 100644
    --- a/drivers/hid/hid-lg4ff.c
    +++ b/drivers/hid/hid-lg4ff.c
    @@ -451,13 +451,13 @@ static ssize_t lg4ff_range_store(struct device *dev, struct device_attribute *at
    drv_data = hid_get_drvdata(hid);
    if (!drv_data) {
    hid_err(hid, "Private driver data not found!\n");
    - return 0;
    + return -EINVAL;
    }

    entry = drv_data->device_props;
    if (!entry) {
    hid_err(hid, "Device properties not found!\n");
    - return 0;
    + return -EINVAL;
    }

    if (range == 0)
    --
    1.9.1


    \
     
     \ /
      Last update: 2014-08-15 05:01    [W:4.990 / U:0.000 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site