Messages in this thread | | | Date | Thu, 14 Aug 2014 15:37:51 -0700 | Subject | Re: [PATCH] ARM: apq8064: Add pinmux and i2c pinctrl nodes | From | Bjorn Andersson <> |
| |
On Thu, Aug 14, 2014 at 12:20 AM, Kiran Padwal <kiran.padwal@smartplayin.com> wrote: > diff --git a/arch/arm/boot/dts/qcom-apq8064.dtsi b/arch/arm/boot/dts/qcom-apq8064.dtsi > index 92bf793..fbebf5c 100644 > --- a/arch/arm/boot/dts/qcom-apq8064.dtsi > +++ b/arch/arm/boot/dts/qcom-apq8064.dtsi > @@ -70,6 +70,17 @@ > ranges; > compatible = "simple-bus"; > > + qcom_pinmux: pinmux@800000 {
There are (at least) three different pinmuxes in these platforms: TLMM, PMIC GPIO, PMIC MPP. Also this is the phandle that is used to reference the gpio chip throughout the board.
So I would like to suggest that we name it "tlmm" or like in the downstream kernel "msmgpio".
> + compatible = "qcom,apq8064-pinctrl"; > + reg = <0x800000 0x4000>; > + > + gpio-controller; > + #gpio-cells = <2>; > + interrupt-controller; > + #interrupt-cells = <2>; > + interrupts = <0 32 0x4>;
I must have gotten this wrong in the dt binding example, sorry about that. interrupts should be <0 16 0x4>.
> + };
Regards, Bjorn
| |