Messages in this thread | | | Date | Thu, 14 Aug 2014 14:39:29 -0700 (PDT) | Subject | Re: [PATCH] tcp: don't use timestamp from repaired skb-s to calculate RTT (v2) | From | David Miller <> |
| |
From: Andrey Vagin <avagin@openvz.org> Date: Wed, 13 Aug 2014 16:03:10 +0400
> We don't know right timestamp for repaired skb-s. Wrong RTT estimations > isn't good, because some congestion modules heavily depends on it. > > This patch adds the TCPCB_REPAIRED flag, which is included in > TCPCB_RETRANS. > > Thanks to Eric for the advice how to fix this issue. > > This patch fixes the warning: ... > v2: moving setting of skb->when for repaired skb-s in tcp_write_xmit, > where it's set for other skb-s. > > Fixes: 431a91242d8d ("tcp: timestamp SYN+DATA messages") > Fixes: 740b0f1841f6 ("tcp: switch rtt estimations to usec resolution") > Cc: Eric Dumazet <edumazet@google.com> > Cc: Pavel Emelyanov <xemul@parallels.com> > Cc: "David S. Miller" <davem@davemloft.net> > Signed-off-by: Andrey Vagin <avagin@openvz.org>
Applied.
| |