lkml.org 
[lkml]   [2014]   [Aug]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH] mmc: dw_mmc: Remove architecture dependency
    From
    > In general, it's best to have specific dependencies on the subsystem
    > a driver uses. You probably need something like
    >
    > depends on HAS_IOMEM && COMMON_CLK && REGULATOR
    > depends on COMPILE_TEST || ARC || ARM || MIPS
    >
    > to cover all the possible cases. The specific options are probably
    > not the ones I listed above, but you should get the idea. Most importantly,
    > you don't want to allow building the driver on architectures on which
    > it can't compile.

    The only compile-time dependencies I see are HAS_IOMEM (which MMC
    already depends on) and HAS_DMA. There isn't any compile-time
    dependency on COMMON_CLK, REGULATOR, GPIOLIB, OF, etc. I've compiled
    it successfully for a few non-ARM/ARC architectures, though that
    certainly isn't an exhaustive test. To be safe though, perhaps I'll
    just update the architecture dependency to include MIPS ||
    COMPILE_TEST as you suggested.


    \
     
     \ /
      Last update: 2014-08-14 02:21    [W:5.272 / U:0.832 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site