Messages in this thread | | | From | Chao Yu <> | Subject | RE: [PATCH] zram: fix incorrectly stat with failed_reads | Date | Wed, 13 Aug 2014 09:59:17 +0800 |
| |
Hi Minchan,
> -----Original Message----- > From: Minchan Kim [mailto:minchan@kernel.org] > Sent: Tuesday, August 12, 2014 3:38 PM > To: Chao Yu > Cc: ngupta@vflare.org; linux-kernel@vger.kernel.org; Jerome Marchand; Sergey Senozhatsky; > Andrew Morton > Subject: Re: [PATCH] zram: fix incorrectly stat with failed_reads > > On Mon, Aug 11, 2014 at 04:39:17PM +0800, Chao Yu wrote: > > Since we allocate a temporary buffer in zram_bvec_read to handle partial page > > operations in this commit 924bd88d703e53d30f393fac6117f8f1bc79aab6 (Staging: > > zram: allow partial page operations), our ->failed_reads value may be incorrect > > as we do not increase its value when failed to allocate the temporary buffer. > > > > Let's fix this issue and correct the annotation of failed_reads.
[snip]
> How abouting moving failed_reads/writes in zram_bvec_rw? > > int zram_bvec_rw(..) > { > if (rw == READ) { > atomic64_inc(num_reads); > ret = zram_bvec_read(xxx); > } else { > atomic64_inc(&num_writes); > ret = zram_bvec_write(xxx); > } > > if (unlikely(ret)) { > if (rw == READ) > atomic64_inc(failed_reads); > else > atomic64_inc(failed_writes); > } > }
I will send a v2 patch base on above codes of yours, please help to review the following new patch.
> > > > > > > -- > > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > > the body of a message to majordomo@vger.kernel.org > > More majordomo info at http://vger.kernel.org/majordomo-info.html > > Please read the FAQ at http://www.tux.org/lkml/ > > -- > Kind regards, > Minchan Kim
| |