Messages in this thread | | | From | David Matlack <> | Date | Tue, 12 Aug 2014 14:18:45 -0700 | Subject | Re: [PATCH 1/2] KVM: fix cache stale memslot info with correct mmio generation number |
| |
On Mon, Aug 11, 2014 at 10:02 PM, Xiao Guangrong <xiaoguangrong@linux.vnet.ibm.com> wrote: > @@ -722,9 +719,10 @@ static struct kvm_memslots *install_new_memslots(struct kvm *kvm, > { > struct kvm_memslots *old_memslots = kvm->memslots; >
I think you want
slots->generation = old_memslots->generation;
here.
On the KVM_MR_DELETE path, install_new_memslots is called twice so this patch introduces a short window of time where the generation number actually decreases.
> - update_memslots(slots, new, kvm->memslots->generation); > + update_memslots(slots, new); > rcu_assign_pointer(kvm->memslots, slots); > synchronize_srcu_expedited(&kvm->srcu); > + slots->generation++; > > kvm_arch_memslots_updated(kvm); > > -- > 1.8.3.1 >
| |