lkml.org 
[lkml]   [2014]   [Aug]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3 5/7] arm: kgdb: Handle read-only text / modules
On 08/12/14 11:24, Kees Cook wrote:
> @@ -244,6 +248,32 @@ void kgdb_arch_exit(void)
> unregister_die_notifier(&kgdb_notifier);
> }
>
> +int kgdb_arch_set_breakpoint(struct kgdb_bkpt *bpt)
> +{
> + int err;
> +
> + /* patch_text() only supports int-sized breakpoints */
> + if (sizeof(int) != BREAK_INSTR_SIZE)
> + return -EINVAL;

Could this be a BUILD_BUG_ON too?

--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by The Linux Foundation



\
 
 \ /
  Last update: 2014-08-12 21:41    [W:0.118 / U:0.396 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site