Messages in this thread | | | Date | Mon, 11 Aug 2014 23:31:26 -0700 | From | Guenter Roeck <> | Subject | Re: [PATCH v2] uas: replace WARN_ON_ONCE() with lockdep_assert_held() |
| |
On Tue, Aug 12, 2014 at 02:01:53PM +0800, Greg KH wrote: > On Tue, Aug 12, 2014 at 11:38:37AM +0530, Sanjeev Sharma wrote: > > spin_is_locked() always return false in uniprocessor configuration and therefore it > > would be advise to replace with lockdep_assert_held(). > > Add "on some architectures" in here somewhere, as it's not broken on the > large majority of UP cpus :) > FWIW, it is confirmed broken on mips (32 and 64 bit), ppc, and sparc64. I have not tested on x86. Might be worth trying. arm64 seems to be ok, unless I did something wrong in my test, as well as at least some of the architectures which don't support smp to start with (such as sparc32 or microblaze).
Guenter
| |