Messages in this thread | | | From | Ohad Ben-Cohen <> | Date | Tue, 12 Aug 2014 18:30:42 +0300 | Subject | Re: [PATCH] rpmsg: compute number of buffers to allocate from vrings |
| |
Hi Suman,
On Thu, Jul 3, 2014 at 11:53 PM, Suman Anna <s-anna@ti.com> wrote: > The buffers to be used for communication are allocated during > the rpmsg virtio driver's probe, and the number of buffers is > currently hard-coded to 512. Remove this hard-coded value, as > this can vary from one platform to another or between different > remote processors. Instead, rely on the number of buffers the > virtqueue vring is setup with in the first place.
Is there a specific problem you bumped into which you are fixing with this approach? Can you please describe it?
I'm concerned that coupling the vring size with coherent memory allocated by rpmsg may not be safe. It'd also be an implicit side effect that may surprise users, so let's consider our alternatives.
Thanks, Ohad.
| |