lkml.org 
[lkml]   [2014]   [Aug]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] staging: lustre: lustre: libcfs: workitem.c: Cleaning up missing null-terminate after strncpy call
From
On Sat, Aug 9, 2014 at 4:46 PM, Rickard Strandqvist
<rickard_strandqvist@spectrumdigital.se> wrote:
> Added a guaranteed null-terminate after call to strncpy.
>
> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
> ---
> drivers/staging/lustre/lustre/libcfs/workitem.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/staging/lustre/lustre/libcfs/workitem.c b/drivers/staging/lustre/lustre/libcfs/workitem.c
> index 0a03bf7..60326f2 100644
> --- a/drivers/staging/lustre/lustre/libcfs/workitem.c
> +++ b/drivers/staging/lustre/lustre/libcfs/workitem.c
> @@ -365,6 +365,7 @@ cfs_wi_sched_create(char *name, struct cfs_cpt_table *cptab,
> return -ENOMEM;
>
> strncpy(sched->ws_name, name, CFS_WS_NAME_LEN);
> + sched->ws_name[CFS_WS_NAME_LEN - 1] = '\0';
> sched->ws_cptab = cptab;
> sched->ws_cpt = cpt;

This seems like a place for strlcpy instead?

-Kees

--
Kees Cook
Chrome OS Security


\
 
 \ /
  Last update: 2014-08-12 17:21    [W:0.073 / U:0.628 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site