Messages in this thread | | | Date | Tue, 12 Aug 2014 16:58:19 +0200 | From | Ingo Molnar <> | Subject | Re: [PATCH 05/33] perf record: Allow the user to disable time stamps |
| |
* Arnaldo Carvalho de Melo <acme@kernel.org> wrote:
> Em Tue, Aug 05, 2014 at 08:08:56AM +0200, Ingo Molnar escreveu: > > * Arnaldo Carvalho de Melo <acme@kernel.org> wrote: > > > From: Andi Kleen <ak@linux.intel.com> > > > This patch looks dangerous and misleading to me. > > I took it more from the angle: hey, it fixes a regression, i.e. > -T/--time somehow became a noop, and also it doesn't change any > default. > > It also states that you will get misaccounting, why that would > happen, althought wording could've been better, as mmaps won't be > "missing", i.e. they will be there as this governs just > PERF_SAMPLE_TIME, not perf_event_attr.mmap, so it MMAPs may come > after samples for its maps. > > So, I took it. > > How should we proceed?
I'd be fine with applying the patch and fixing the misleading changelog.
Thanks,
Ingo
| |