Messages in this thread | | | Date | Tue, 12 Aug 2014 16:28:44 +0200 (CEST) | From | Jiri Kosina <> | Subject | Re: [PATCH] HID: hid-sensor-hub: use devm_ functions consistently |
| |
On Sat, 2 Aug 2014, Srinivas Pandruvada wrote:
> > Use devm_kzalloc for all calls to kzalloc and not just the first. Use > > devm functions for other allocations as well. The calls to free the > > allocated memory in the probe and remove functions are done away with > > and a label is removed in the probe function. > > > > The semantic match that finds the inconsistency is as follows: > > > > // <smpl> > > @@ > > @@ > > > > *devm_kzalloc(...) > > ... > > *kzalloc(...) > > // </smpl> > > > > Signed-off-by: Himangi Saraogi <himangi774@gmail.com> > > Acked-by: Julia Lawall <julia.lawall@lip6.fr> > Reviewed-by: Srinivas Pandruvada <srinivas.pandruvada@intel.com>
Queued for 3.17, thanks.
-- Jiri Kosina SUSE Labs
| |