Messages in this thread | | | Date | Tue, 12 Aug 2014 12:58:37 +0200 | From | Vlastimil Babka <> | Subject | Re: [PATCH v2 5/8] mm/isolation: change pageblock isolation logic to fix freepage counting bugs |
| |
On 08/12/2014 08:43 AM, Minchan Kim wrote: >> --- a/mm/page_alloc.c >> +++ b/mm/page_alloc.c >> @@ -571,7 +571,7 @@ static inline int page_is_buddy(struct page *page, struct page *buddy, >> * -- nyc >> */ >> >> -static inline void __free_one_page(struct page *page, >> +void __free_one_page(struct page *page, > > no inline any more. :(
That could be hopefully done differently without killing this property.
> Personally, it is becoming increasingly clear that it would be better > to add some hooks for isolateed pages to be sure to fix theses problems > without adding more complicated logic.
Might be a valid argument but please do read the v1 discussions and then say if you still hold the opinion. Or maybe you will get a better picture afterwards and see a more elegant solution :)
Vlastimil
| |