Messages in this thread | | | Date | Tue, 12 Aug 2014 12:53:21 +0300 | From | Mika Westerberg <> | Subject | Re: [PATCH] I2C: Make I2C core able to be module when I2C_ACPI is selected. |
| |
On Mon, Aug 11, 2014 at 03:00:55PM +0800, Lan Tianyu wrote: > Commit da3c6647(I2C/ACPI: Clean up I2C ACPI code and Add CONFIG_I2C_ACPI > config) adds a new kernel config I2C_ACPI and make I2C core built in > when the config is selected. This is wrong because distributions > etc generally compile I2C as a module and the commit broken that. > This patch is to make I2C core able to be a module when I2C_ACPI is > selected. Original issue the commit da3c6647 tried to avoid will > be fixed in ACPICA and it's rarely triggered during unloading module. > > Signed-off-by: Lan Tianyu <tianyu.lan@intel.com>
I wonder if we can do
depends on I2C=y
here? If I understand it right, then we only build the ACPI_I2C if I2C is compiled into the kernel. That way the problem da3c6647 tried to solve doens't re-appear.
We can later on relax this once ACPICA has been fixed. Thoughts?
| |