lkml.org 
[lkml]   [2014]   [Aug]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 5/5] platform: Make platform_bus device a platform device
From
Date
On Sat, 2014-07-26 at 21:13 +0100, Greg Kroah-Hartman wrote:
> > @@ -946,12 +946,20 @@ int __init platform_bus_init(void)
> >
> > early_platform_cleanup();
> >
> > - error = device_register(&platform_bus);
> > + dev_set_name(&platform_bus.dev, "%s", platform_bus.name);
> > + error = device_register(&platform_bus.dev);
> > if (error)
> > return error;
> > error = bus_register(&platform_bus_type);
> > - if (error)
> > - device_unregister(&platform_bus);
> > + if (!error) {
> > +#ifdef CONFIG_OF
> > + platform_bus.dev.of_node = of_allnodes;
> > +#endif
>
> Why are you doing this? The original code didn't do it and all was
> fine, right? What changes here?

You mean the #ifdef? It wasn't there, but Olof figured out that it
breaks !CONFIG_OF builds:

http://article.gmane.org/gmane.linux.ports.tegra/18473

as of_allnodes is only defined when CONFIG_OF. I had a choice of
#ifdefing the assignment above or providing a dummy symbol. The latter
doesn't seem sensibly, as there should be no other users for it (the
symbol).

Pawel



\
 
 \ /
  Last update: 2014-08-01 20:01    [W:0.189 / U:0.556 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site