lkml.org 
[lkml]   [2014]   [Aug]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v2 tip/core/rcu 01/10] rcu: Add call_rcu_tasks()
    On 07/30, Paul E. McKenney wrote:
    >
    > + rcu_read_lock();
    > + for_each_process_thread(g, t) {
    > + if (t != current && ACCESS_ONCE(t->on_rq) &&
    > + !is_idle_task(t)) {
    > + t->rcu_tasks_nvcsw = ACCESS_ONCE(t->nvcsw);
    > + t->rcu_tasks_holdout = 1;
    > + list_add(&t->rcu_tasks_holdout_list,
    > + &rcu_tasks_holdouts);
    > + }
    > + }
    > + rcu_read_unlock();

    Wait, unless I missed something this can't work...

    The problem is, once the exiting task passes exit_notify() it can
    be removed from rcu lists.

    Now suppose that (say) proc_exit_connector() has a probe, and this
    task has jumped into trampoline and it was preempted there.

    No?

    Oleg.



    \
     
     \ /
      Last update: 2014-08-01 18:21    [W:3.041 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site