lkml.org 
[lkml]   [2014]   [Jul]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] usb: usb3503: return correct error return on failure
On Sun, Jun 29, 2014 at 10:42:53PM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Fix warning: drivers/usb/misc/usb3503.c:195:11: warning: 'err'
> may be used uninitialized in this function [-Wmaybe-uninitialized]
>
> err is not initialized, the error return should be PTR_ERR(clk)
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> Reviewed-by: Jingoo Han <jg1.han@samsung.com>
> ---
> drivers/usb/misc/usb3503.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/usb/misc/usb3503.c b/drivers/usb/misc/usb3503.c
> index f43c619..c0c898d 100644
> --- a/drivers/usb/misc/usb3503.c
> +++ b/drivers/usb/misc/usb3503.c
> @@ -192,7 +192,8 @@ static int usb3503_probe(struct usb3503 *hub)
>
> clk = devm_clk_get(dev, "refclk");
> if (IS_ERR(clk) && PTR_ERR(clk) != -ENOENT) {
> - dev_err(dev, "unable to request refclk (%d)\n", err);
> + dev_err(dev, "unable to request refclk (%ld)\n",
> + PTR_ERR(clk));
> return PTR_ERR(clk);
> }
>

This doesn't apply to my tree at all :(


\
 
 \ /
  Last update: 2014-07-10 01:41    [W:0.129 / U:0.440 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site