Messages in this thread | | | Date | Wed, 9 Jul 2014 15:35:21 -0700 | Subject | Re: [PATCHv4 1/5] lib/genalloc.c: Add power aligned algorithm | From | Olof Johansson <> |
| |
On Thu, Jul 3, 2014 at 11:10 AM, Will Deacon <will.deacon@arm.com> wrote: > On Wed, Jul 02, 2014 at 07:03:34PM +0100, Laura Abbott wrote: >> >> One of the more common algorithms used for allocation >> is to align the start address of the allocation to >> the order of size requested. Add this as an algorithm >> option for genalloc. >> >> Signed-off-by: Laura Abbott <lauraa@codeaurora.org> >> --- >> include/linux/genalloc.h | 4 ++++ >> lib/genalloc.c | 20 ++++++++++++++++++++ >> 2 files changed, 24 insertions(+) >> >> diff --git a/include/linux/genalloc.h b/include/linux/genalloc.h >> index 1c2fdaa..3cd0934 100644 >> --- a/include/linux/genalloc.h >> +++ b/include/linux/genalloc.h >> @@ -110,6 +110,10 @@ extern void gen_pool_set_algo(struct gen_pool *pool, genpool_algo_t algo, >> extern unsigned long gen_pool_first_fit(unsigned long *map, unsigned long size, >> unsigned long start, unsigned int nr, void *data); >> >> +extern unsigned long gen_pool_first_fit_order_align(unsigned long *map, >> + unsigned long size, unsigned long start, unsigned int nr, >> + void *data); >> + > > You could also update gen_pool_first_fit to call this new function instead.
+1, that'd be slightly nicer and remove one exported symbol.
But, as Will says, up to you. Either option:
Acked-by: Olof Johansson <olof@lixom.net>
| |