Messages in this thread | | | From | "Luck, Tony" <> | Subject | RE: [PATCH 5/6] x86-mce: check if no_way_out applies before deciding not to clear MCE banks. | Date | Wed, 9 Jul 2014 21:00:17 +0000 |
| |
+ if (!(no_way_out && cfg->tolerant < 3)) mce_clear_state(toclear);
Style - I think this is easier to grok:
if (!no_way_out || cfg->tolerant >=3) mce_clear_state(toclear);
but not too strongly if other like !(a && b) form.
I'm never sure how to treat the crazy levels of "tolerant" though. Do we really want to clear the banks? In one sense we do ... we are still running and might see more UC errors. Since newer UC errors don't overwrite older ones, clearing the banks allows us to see how many errors are piling up and being ignored.
But running with tolerant==3 is likely to end in tears ... should we erase the evidence on what bad things happened?
-Tony
| |