lkml.org 
[lkml]   [2014]   [Jul]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH 5/6] x86-mce: check if no_way_out applies before deciding not to clear MCE banks.
Date
+	if (!(no_way_out && cfg->tolerant < 3))
mce_clear_state(toclear);

Style - I think this is easier to grok:

if (!no_way_out || cfg->tolerant >=3)
mce_clear_state(toclear);

but not too strongly if other like !(a && b) form.

I'm never sure how to treat the crazy levels of "tolerant" though. Do
we really want to clear the banks? In one sense we do ... we are still
running and might see more UC errors. Since newer UC errors don't
overwrite older ones, clearing the banks allows us to see how many
errors are piling up and being ignored.

But running with tolerant==3 is likely to end in tears ... should we erase
the evidence on what bad things happened?

-Tony


\
 
 \ /
  Last update: 2014-07-10 00:01    [W:0.312 / U:0.520 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site