Messages in this thread | | | Date | Wed, 9 Jul 2014 15:18:36 -0400 | From | Tejun Heo <> | Subject | Re: [PATCH v3 05/12] cpuset: use effective cpumask to build sched domains |
| |
On Wed, Jul 09, 2014 at 04:47:50PM +0800, Li Zefan wrote: > + /* > + * If the effective cpumask of any non-empty cpuset is changed, > + * we need to rebuild sched domains. > + */ > + if (!cpumask_empty(cp->cpus_allowed) && > + is_sched_load_balance(cp)) > + need_rebuild_sched_domains = true;
Hmmm... is this because if cpus_allowed is empty, the effective always equals the parent? If so, let's update the comment so that it explains why the code is like that. The current comment just explains what it does which isn't very helpful.
Thanks.
-- tejun
| |