Messages in this thread | | | Date | Tue, 8 Jul 2014 09:51:06 +0200 | From | Maxime Ripard <> | Subject | Re: [PATCH 3/5] ARM: at91/dt: sama5d3: define mpddr clock and ramc clocks |
| |
Hi,
On Mon, Jul 07, 2014 at 09:55:56PM +0200, Alexandre Belloni wrote: > On 07/07/2014 at 20:32:36 +0200, Jean-Christophe PLAGNIOL-VILLARD wrote : > > > - compatible = "atmel,at91sam9g45-ddramc"; > > > + compatible = "atmel,sama5d3-mpddramc", "atmel,at91sam9g45-ddramc"; > > the sama5 ddr controler is not back compitble with 9g45 one the compatible is > > wrong > > Keeping atmel,at91sam9g45-ddramc allows to reuse the old code for the > iomap needed for the PM code without adding a new compatible in the > ramc_ids[] array.
That looks like a pretty bad argument :)
If the two devices are not alike, they should have a different compatible, it's as simple as that, and Linux should just deal with it.
Maxime
-- Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com [unhandled content-type:application/pgp-signature] | |