lkml.org 
[lkml]   [2014]   [Jul]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH v1] PCI: enable ASPM configuration in PCIE POWERSAVE mode
Date
On Sat, 2014-07-05 at 13:02 -0600, Bjorn Helgaas wrote:
> > Rafael, Matthew, any comments? We have vacillated on this before and
> > the web is already pretty tangled.
> >
> > Vidya, can you give more details about the bug fixed by this change?
> > What's the scenario? Are we resuming and the device is powered up but
> > ASPM isn't enabled? Maybe you could collect more details in a
> > http://bugzilla.kernel.org report?

I believe that's the case. The proposed change would fix it but isn't
really terribly clean - I think it would be more readable to split this
into multiple functions.

--
Matthew Garrett <matthew.garrett@nebula.com>
\
 
 \ /
  Last update: 2014-07-07 19:22    [W:0.162 / U:0.856 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site