Messages in this thread | | | Date | Mon, 7 Jul 2014 13:02:48 +0300 | Subject | Re: [PATCH] appletalk: Set skb with destructor | From | Andrey Utkin <> |
| |
2014-07-07 12:26 GMT+03:00 Eric Dumazet <eric.dumazet@gmail.com>: > Reading again this code, I think all you need is to remove the 2 buggy > lines. > > No need for setup destructors.
Reviewing the code again, i find you're right and adding a destructor in that place is stupid, and just not setting skb->sk would make bug disappear, assuming skb->sk is previously NULL. And what about the second case, at ddp.c near line 1650? Is destructor needed here?
-- Andrey Utkin
| |