Messages in this thread | | | Subject | Re: [PATCH 2/4] Staging: rts5208: Use standard print_hex_dump_debug | From | Joe Perches <> | Date | Sun, 06 Jul 2014 09:39:59 -0700 |
| |
On Sun, 2014-07-06 at 18:32 +0200, Fabio Falzoi wrote: > Have I to fix just the commit message or is this behaviour not suitable? > In the latter case, could you please suggest a way to fix this?
Hi Fabio.
I think it's not appropriate. I'd've changed it to something like:
#if DEBUG #define rtsx_hex_dump(buf, len) \ print_hex_dump_bytes(KBUILD_MODNAME ": ", DUMP_PREFIX_NONE, \ buf, len) #else #define rtsx_hex_dump(buf, len) do {;} while (0) #endif
| |