lkml.org 
[lkml]   [2014]   [Jul]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] MIPS: Remove incorrect NULL check in local_flush_tlb_page()
On Sun, 6 Jul 2014, Jonas Gorski wrote:

> On Sun, Jul 6, 2014 at 1:23 AM, Emil Goode <emilgoode@gmail.com> wrote:
> > We check that the struct vm_area_struct pointer vma is NULL and then
> > dereference it a few lines below. The intent was to make sure vma is
> > not NULL but this is not necessary since the bug pre-dates GIT history
> > and seem to never have caused a problem. The tlb-4k and tlb-8k versions
> > of local_flush_tlb_page() don't bother checking if vma is NULL, also
> > vma is dereferenced before being passed to local_flush_tlb_page(),
> > thus it is safe to remove this NULL check.
> >
> > Signed-off-by: Emil Goode <emilgoode@gmail.com>
>
> Looks good.
>
> Reviewed-by: Jonas Gorski <jogo@openwrt.org>

Acked-by: Maciej W. Rozycki <macro@linux-mips.org>

(as per the observations at the previous version).

Maciej


\
 
 \ /
  Last update: 2014-07-06 13:41    [W:0.054 / U:0.360 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site