lkml.org 
[lkml]   [2014]   [Jul]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 1/1] drm/omap: remove null test before kfree
From
Hi

On Fri, Jul 4, 2014 at 9:17 PM, Fabian Frederick <fabf@skynet.be> wrote:
> Fix checkpatch warning:
> WARNING: kfree(NULL) is safe this check is probably not required
>
> Cc: David Airlie <airlied@linux.ie>
> Cc: David Herrmann <dh.herrmann@gmail.com>
> Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>
> Cc: dri-devel@lists.freedesktop.org
> Signed-off-by: Fabian Frederick <fabf@skynet.be>

Reviewed-by: David Herrmann <dh.herrmann@gmail.com>

Thanks
David

> ---
> drivers/gpu/drm/omapdrm/omap_gem.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/omapdrm/omap_gem.c b/drivers/gpu/drm/omapdrm/omap_gem.c
> index 95dbce2..be0c2e8 100644
> --- a/drivers/gpu/drm/omapdrm/omap_gem.c
> +++ b/drivers/gpu/drm/omapdrm/omap_gem.c
> @@ -1183,9 +1183,7 @@ int omap_gem_op_sync(struct drm_gem_object *obj, enum omap_gem_op op)
> }
> }
> spin_unlock(&sync_lock);
> -
> - if (waiter)
> - kfree(waiter);
> + kfree(waiter);
> }
> return ret;
> }
> --
> 1.9.1
>


\
 
 \ /
  Last update: 2014-07-06 13:01    [W:0.032 / U:0.044 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site