lkml.org 
[lkml]   [2014]   [Jul]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/1] drivers/pci/hotplug/cpqphp_sysfs.c: remove unnecessary null test before debugfs_remove
On Sat, Jun 28, 2014 at 11:44:43AM +0200, Fabian Frederick wrote:
> Fix checkpatch warning:
> "WARNING: debugfs_remove(NULL) is safe this check is probably not required"
>
> Cc: Bjorn Helgaas <bhelgaas@google.com>
> Cc: Ryan Desfosses <ryan@desfo.org>
> Cc: linux-pci@vger.kernel.org
> Signed-off-by: Fabian Frederick <fabf@skynet.be>

Applied to pci/hotplug for v3.17, thanks!

> ---
> drivers/pci/hotplug/cpqphp_sysfs.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/pci/hotplug/cpqphp_sysfs.c b/drivers/pci/hotplug/cpqphp_sysfs.c
> index 4a392c4..d81648f 100644
> --- a/drivers/pci/hotplug/cpqphp_sysfs.c
> +++ b/drivers/pci/hotplug/cpqphp_sysfs.c
> @@ -216,8 +216,7 @@ void cpqhp_create_debugfs_files(struct controller *ctrl)
>
> void cpqhp_remove_debugfs_files(struct controller *ctrl)
> {
> - if (ctrl->dentry)
> - debugfs_remove(ctrl->dentry);
> + debugfs_remove(ctrl->dentry);
> ctrl->dentry = NULL;
> }
>
> --
> 1.8.4.5
>


\
 
 \ /
  Last update: 2014-07-05 20:21    [W:0.027 / U:2.496 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site