lkml.org 
[lkml]   [2014]   [Jul]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    Subject[stable] please do not merge 058504edd026 (was Re: fs: use after free in /proc/pid/mountinfo)
    On Fri, 4 Jul 2014, Sasha Levin wrote:

    > > Does this now reproduce on Linus's tree? If so, does reverting commit
    > > 058504edd026 ("fs/seq_file: fallback to vmalloc allocation") prevent this
    > > issue?
    > >
    > > This is a use-after-free since the poison value is 0x6b and I'm presuming
    > > that your /proc/self/mountinfo may be larger than PAGE_SIZE in your
    > > testing environment.
    > >
    >
    > Good call, reverting that patch made both issues go away.
    >

    Thanks for checking, Sasha.

    Stable maintainers, please do not merge commit 058504edd026 ("fs/seq_file:
    fallback to vmalloc allocation") that is annotated with a cc for
    stable@vger.kernel.org in Linus's tree into stable kernels.

    Although we're at 3.16-rc3, I'm hoping that we can get a fix for the
    use-after-free in the next couple days before asking for a revert. Sasha
    confirms[*] this commit causes the bug.

    Thanks.

    [*] http://marc.info/?l=linux-kernel&m=140448573612154


    \
     
     \ /
      Last update: 2014-07-05 01:21    [W:4.630 / U:0.092 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site